Adds ExtraFieldCustomizer for ... customizing extra fields#981
Merged
codefromthecrypt merged 3 commits intomasterfrom Aug 30, 2019
Merged
Adds ExtraFieldCustomizer for ... customizing extra fields#981codefromthecrypt merged 3 commits intomasterfrom
codefromthecrypt merged 3 commits intomasterfrom
Conversation
This will allow you to change field setup without accidentally overriding the trace propagation format. Like #978, except for extra fields. I realize this dramatically simplifies our spring 2.5 variant of brave-webmvc-example along the way.
added 2 commits
August 30, 2019 10:18
devinsba
approved these changes
Aug 30, 2019
Member
devinsba
left a comment
devinsba
left a comment
There was a problem hiding this comment.
Cool, is there value in one of these for CurrentTraceContext also?
Member
Author
|
you mean for scope decorators? probably. If you are up for it, go for it.. otherwise I'll try a hand later. will be afk a bit tomorrow. |
Member
Author
|
#983 for context customizer.. I think that's all of them at this point. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow you to change field setup without accidentally
overriding the trace propagation format.
Like #978, except for extra fields. I realize this dramatically
simplifies our spring 2.5 variant of brave-webmvc-example along the way.